Browse Source

EAGLESIX-1695 in preparation for another merge with expressions

Tony Ennis 11 years ago
parent
commit
c8b67190ec

+ 0 - 5
lib/pipeline/expressions/LetExpression.js

@@ -119,14 +119,9 @@ proto.addDependencies = function addDependencies(deps, path){
 			var first = id,
 				second = this._variables[first][name];
 			second._expressions[name].addDependencies(deps);
-//			this._variables[id][name].addDependencies(deps);
 		}
 	}
 	this._subExpression.addDependencies(deps);
-	return deps; //NOTE: DEVIATION FROM MONGO: The c++ version does not return a value. We seem to use the returned value
-					// (or something from a different method named
-					// addDependencies) in many places.
-
 };
 
 Expression.registerExpression("$let", LetExpression.parse);

+ 2 - 2
test/lib/pipeline/expressions/LetExpression_test.js

@@ -86,7 +86,7 @@ module.exports = {
 					assert.deepEqual(x._variables[0].a._expressions.a.getValue(), 1);
 					assert.deepEqual(x._variables[1].b._expressions.b.getValue(), 2);
 					assert.deepEqual(x._variables[2].c._expressions.c.getValue(), 3);
-				},
+				}
 			},
 
 			"#optimize()": {
@@ -160,7 +160,7 @@ module.exports = {
 					y = x.evaluate(new Variables(10, {price: 90, tax: .05, applyDiscount: 1}));
 					assert.equal(y, 90.05 * .9);
 				}
-			},
+			}
 		}
 	}
 };